Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double compress when compression enabled and compressed file exists (#8014) #8017

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 11, 2024

(cherry picked from commit 92655a5)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fca5a7a) 97.32% compared to head (cd5261f) 97.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #8017      +/-   ##
==========================================
+ Coverage   97.32%   97.39%   +0.06%     
==========================================
  Files         108      108              
  Lines       32474    32493      +19     
  Branches     3845     3845              
==========================================
+ Hits        31604    31645      +41     
+ Misses        664      646      -18     
+ Partials      206      202       -4     
Flag Coverage Δ
CI-GHA 97.30% <100.00%> (+0.06%) ⬆️
OS-Linux 96.99% <100.00%> (+0.06%) ⬆️
OS-Windows 94.48% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.81% <100.00%> (+0.29%) ⬆️
Py-3.10.11 94.37% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.11.7 96.53% <100.00%> (+0.03%) ⬆️
Py-3.12.1 96.58% <100.00%> (+0.03%) ⬆️
Py-3.8.10 94.35% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.37% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.75% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.14 96.30% <100.00%> (?)
VM-macos 96.81% <100.00%> (+0.29%) ⬆️
VM-ubuntu 96.99% <100.00%> (+0.06%) ⬆️
VM-windows 94.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review January 11, 2024 01:51
@bdraco bdraco requested a review from asvetlov as a code owner January 11, 2024 01:51
@bdraco bdraco merged commit f93e55c into 3.9 Jan 11, 2024
29 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.9/92655a50987e8bdfb6241dabbedc4c3cc8f55272/pr-8014 branch January 11, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant