Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about tasks that should be cancelled on shutdown #8267

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add note about tasks that should be cancelled on shutdown #8267

merged 3 commits into from
Mar 29, 2024

Conversation

Dreamsorcerer
Copy link
Member

Closes #8179.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 29, 2024
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) March 29, 2024 23:17
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (779505c) to head (8422bd6).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8267      +/-   ##
==========================================
- Coverage   97.56%   97.49%   -0.07%     
==========================================
  Files         107      107              
  Lines       32921    32986      +65     
  Branches     3851     3853       +2     
==========================================
+ Hits        32120    32161      +41     
- Misses        586      606      +20     
- Partials      215      219       +4
Flag Coverage Δ
CI-GHA 97.42% <ø> (-0.06%) ⬇️
OS-Linux 97.08% <ø> (-0.06%) ⬇️
OS-Windows 95.71% <ø> (+<0.01%) ⬆️
OS-macOS 96.85% <ø> (-0.01%) ⬇️
Py-3.10.11 95.56% <ø> (+<0.01%) ⬆️
Py-3.10.13 96.70% <ø> (+<0.01%) ⬆️
Py-3.10.14 96.92% <ø> (+<0.01%) ⬆️
Py-3.11.8 97.14% <ø> (+<0.01%) ⬆️
Py-3.12.2 97.26% <ø> (+<0.01%) ⬆️
Py-3.8.10 95.53% <ø> (+<0.01%) ⬆️
Py-3.8.18 96.89% <ø> (+<0.01%) ⬆️
Py-3.9.13 95.53% <ø> (+<0.01%) ⬆️
Py-3.9.18 96.66% <ø> (-0.01%) ⬇️
Py-3.9.19 96.89% <ø> (+<0.01%) ⬆️
Py-pypy7.3.15 ?
VM-macos 96.85% <ø> (-0.01%) ⬇️
VM-ubuntu 97.08% <ø> (-0.06%) ⬇️
VM-windows 95.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 509fb26 into master Mar 29, 2024
34 of 35 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch March 29, 2024 23:49
@patchback Patchback
Copy link
Contributor

patchback bot commented Mar 29, 2024 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/509fb269ac7ed0fe9ad387eccf7d1112aa9c0e65/pr-8267

Backported as #8268

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2024
@Dreamsorcerer @patchback
Add note about tasks that should be cancelled on shutdown (#8267)
97f19c0 
(cherry picked from commit 509fb26)
@patchback patchback bot mentioned this pull request Mar 29, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Mar 29, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/509fb269ac7ed0fe9ad387eccf7d1112aa9c0e65/pr-8267

Backported as #8269

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2024
@Dreamsorcerer @patchback
Add note about tasks that should be cancelled on shutdown (#8267)
27c8d61 
(cherry picked from commit 509fb26)
@patchback patchback bot mentioned this pull request Mar 29, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Mar 30, 2024
@patchback @Dreamsorcerer
[PR #8267/509fb269 backport][3.9] Add note about tasks that should be…
3a13bd5 
… cancelled on shutdown (#8268)

**This is a backport of PR #8267 as merged into master
(509fb26).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Mar 30, 2024
@patchback @Dreamsorcerer
[PR #8267/509fb269 backport][3.10] Add note about tasks that should b…
d10bd0a 
…e cancelled on shutdown (#8269)

**This is a backport of PR #8267 as merged into master
(509fb26).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong server shutdown order?
2 participants
@Dreamsorcerer @bdraco