Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition with request handlers on shutdown #8271

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Fix race condition with request handlers on shutdown #8271

merged 2 commits into from
Mar 30, 2024

Conversation

Dreamsorcerer
Copy link
Member

Fixes #8212.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner March 30, 2024 17:43
@Dreamsorcerer Dreamsorcerer requested a review from webknjaz as a code owner March 30, 2024 17:45
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 30, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (509fb26) to head (8995775).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8271   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         107      107           
  Lines       32986    32987    +1     
  Branches     3853     3853           
=======================================
+ Hits        32183    32184    +1     
  Misses        588      588           
  Partials      215      215
Flag Coverage Δ
CI-GHA 97.48% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.14% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.71% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.92% <100.00%> (+<0.01%) ⬆️
Py-3.11.8 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.26% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.53% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.89% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.66% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.89% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.45% <100.00%> (+<0.01%) ⬆️
VM-macos 96.85% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.14% <100.00%> (+<0.01%) ⬆️
VM-windows 95.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit e0d9d3a into master Mar 30, 2024
36 of 37 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch March 30, 2024 23:05
@patchback Patchback
Copy link
Contributor

patchback bot commented Mar 30, 2024 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/e0d9d3ab9417cea6d25a37a75d12d3a9c1755a8b/pr-8271

Backported as #8272

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 30, 2024
@Dreamsorcerer @patchback
Fix race condition with request handlers on shutdown (#8271)
651f970 
(cherry picked from commit e0d9d3a)
@patchback patchback bot mentioned this pull request Mar 30, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Mar 30, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/e0d9d3ab9417cea6d25a37a75d12d3a9c1755a8b/pr-8271

Backported as #8273

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 30, 2024
@Dreamsorcerer @patchback
Fix race condition with request handlers on shutdown (#8271)
40fbac5 
(cherry picked from commit e0d9d3a)
@patchback patchback bot mentioned this pull request Mar 30, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Mar 31, 2024
@patchback @Dreamsorcerer
[PR #8271/e0d9d3ab backport][3.9] Fix race condition with request han…
46e8f64 
…dlers on shutdown (#8272)

**This is a backport of PR #8271 as merged into master
(e0d9d3a).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Mar 31, 2024
@patchback @Dreamsorcerer
[PR #8271/e0d9d3ab backport][3.10] Fix race condition with request ha…
f74026a 
…ndlers on shutdown (#8273)

**This is a backport of PR #8271 as merged into master
(e0d9d3a).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stability issues with gunicorn --max-requests
2 participants
@Dreamsorcerer @bdraco