Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reliability of run_app test #8309

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Improve reliability of run_app test #8309

merged 4 commits into from
Apr 8, 2024

Conversation

Dreamsorcerer
Copy link
Member

Have seen a flaky test failure where the server failed to accept the request in time, on mac.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels Apr 7, 2024
@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner April 7, 2024 22:59
@codecov Codecov
Copy link

codecov bot commented Apr 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (28d026e) to head (17ae470).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8309   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         107      107           
  Lines       33025    33027    +2     
  Branches     3874     3873    -1     
=======================================
+ Hits        32214    32216    +2     
  Misses        591      591           
  Partials      220      220
Flag Coverage Δ
CI-GHA 97.51% <100.00%> (+0.05%) ⬆️
OS-Linux 97.12% <100.00%> (+<0.01%) ⬆️
OS-Windows 97.31% <100.00%> (+1.69%) ⬆️
OS-macOS 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.46% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.92% <100.00%> (-0.01%) ⬇️
Py-3.11.8 97.12% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.45% <100.00%> (+0.20%) ⬆️
Py-3.8.10 95.39% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.43% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.89% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.43% <100.00%> (+<0.01%) ⬆️
VM-macos 96.83% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.12% <100.00%> (+<0.01%) ⬆️
VM-windows 97.31% <100.00%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit c29945a into master Apr 8, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-6 branch April 8, 2024 17:45
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 8, 2024 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/c29945a19ef93ac05f7499bfc410e234270ddbb3/pr-8309

Backported as #8315

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 8, 2024
@Dreamsorcerer @patchback
Improve reliability of run_app test (#8309)
2b21632 
(cherry picked from commit c29945a)
@patchback patchback bot mentioned this pull request Apr 8, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 8, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/c29945a19ef93ac05f7499bfc410e234270ddbb3/pr-8309

Backported as #8316

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 8, 2024
@Dreamsorcerer @patchback
Improve reliability of run_app test (#8309)
baa498a 
(cherry picked from commit c29945a)
@patchback patchback bot mentioned this pull request Apr 8, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Apr 8, 2024
@patchback @Dreamsorcerer
[PR #8309/c29945a1 backport][3.10] Improve reliability of run_app test (
b2a1f98 
#8316)

**This is a backport of PR #8309 as merged into master
(c29945a).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Apr 8, 2024
@patchback @Dreamsorcerer
[PR #8309/c29945a1 backport][3.9] Improve reliability of run_app test (…
ed43040 
…#8315)

**This is a backport of PR #8309 as merged into master
(c29945a).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dreamsorcerer