Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Content-Disposition automatically #8335

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Add Content-Disposition automatically #8335

merged 8 commits into from
Apr 15, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Apr 15, 2024 •
edited
Loading

Fixes #8326.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner April 15, 2024 16:13
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 15, 2024
View reviewed changes
tests/test_multipart.py Fixed Show fixed Hide fixed
tests/test_multipart.py Fixed Show fixed Hide fixed
@Dreamsorcerer Dreamsorcerer requested a review from webknjaz as a code owner April 15, 2024 16:37
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 15, 2024
Dreamsorcerer
Dreamsorcerer commented Apr 15, 2024
View reviewed changes
aiohttp/multipart.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (482e6cd) to head (306b461).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8335      +/-   ##
==========================================
- Coverage   97.55%   97.48%   -0.07%     
==========================================
  Files         107      107              
  Lines       33056    33069      +13     
  Branches     3880     3882       +2     
==========================================
- Hits        32247    32238       -9     
- Misses        589      607      +18     
- Partials      220      224       +4
Flag Coverage Δ
CI-GHA 97.41% <100.00%> (-0.06%) ⬇️
OS-Linux 97.07% <100.00%> (-0.06%) ⬇️
OS-Windows 95.57% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.79% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.42% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.12% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 96.95% <100.00%> (-0.31%) ⬇️
Py-3.12.3 95.42% <100.00%> (?)
Py-3.8.10 95.35% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.78% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.91% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 ?
VM-macos 96.79% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.07% <100.00%> (-0.06%) ⬇️
VM-windows 95.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 5a6949d into master Apr 15, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch April 15, 2024 20:16
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 15, 2024 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/5a6949da642d1db6cf414fd0d1f70e54c7b7be14/pr-8335

Backported as #8336

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 15, 2024
@Dreamsorcerer @patchback
Add Content-Disposition automatically (#8335)
c317e08 
(cherry picked from commit 5a6949d)
@patchback patchback bot mentioned this pull request Apr 15, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 15, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/5a6949da642d1db6cf414fd0d1f70e54c7b7be14/pr-8335

Backported as #8337

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 15, 2024
@Dreamsorcerer @patchback
Add Content-Disposition automatically (#8335)
c6e4606 
(cherry picked from commit 5a6949d)
@patchback patchback bot mentioned this pull request Apr 15, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Apr 15, 2024
@patchback @Dreamsorcerer
[PR #8335/5a6949da backport][3.10] Add Content-Disposition automatica…
cdb5129 
…lly (#8337)

**This is a backport of PR #8335 as merged into master
(5a6949d).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Apr 15, 2024
@patchback @Dreamsorcerer
[PR #8335/5a6949da backport][3.9] Add Content-Disposition automatical…
f21c6f2 
…ly (#8336)

**This is a backport of PR #8335 as merged into master
(5a6949d).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
1 participant
@Dreamsorcerer