Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8611/1fcef940 backport][3.10] Fix handler waiting on shutdown #8627

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 7, 2024

This is a backport of PR #8611 as merged into master (1fcef94).

There seems to be some kind of race condition in certain circumstance which can lead to .wait_for_disconnection() being called after the request has already been cancelled.

Additionally, I see no guarantee that when .wait_for_disconnection() completes, that the handler itself has completed (and not suppressed a cancellation etc.).

However, I couldn't figure out a shutdown test in test_run_app.py that triggers this edge case.

@bdraco bdraco enabled auto-merge (squash) August 7, 2024 13:07
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.10@06eedff). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8627   +/-   ##
=======================================
  Coverage        ?   97.57%           
=======================================
  Files           ?      108           
  Lines           ?    33678           
  Branches        ?     4040           
=======================================
  Hits            ?    32861           
  Misses          ?      597           
  Partials        ?      220           
Flag Coverage Δ
CI-GHA 97.47% <100.00%> (?)
OS-Linux 97.14% <100.00%> (?)
OS-Windows 94.68% <100.00%> (?)
OS-macOS 96.81% <100.00%> (?)
Py-3.10.11 96.91% <100.00%> (?)
Py-3.10.14 96.87% <80.00%> (?)
Py-3.11.9 97.11% <100.00%> (?)
Py-3.12.4 97.22% <100.00%> (?)
Py-3.8.10 94.41% <100.00%> (?)
Py-3.8.18 96.77% <80.00%> (?)
Py-3.9.13 96.92% <100.00%> (?)
Py-3.9.19 96.88% <80.00%> (?)
Py-pypy7.3.16 96.44% <80.00%> (?)
VM-macos 96.81% <100.00%> (?)
VM-ubuntu 97.14% <100.00%> (?)
VM-windows 94.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 266608d into 3.10 Aug 7, 2024
30 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/1fcef940e37c93f1dc05b859816affaf7228b2f8/pr-8611 branch August 7, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants