Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #8620 as improvements to various type annotations #8634

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Backport #8620 as improvements to various type annotations #8634

merged 7 commits into from
Aug 7, 2024

Conversation

Dreamsorcerer
Copy link
Member

Without test changes

@Dreamsorcerer Dreamsorcerer added the backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot label Aug 7, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 7, 2024
@Dreamsorcerer Dreamsorcerer reopened this Aug 7, 2024
@bdraco bdraco changed the title Backport #8620 Backport #8620 as improvements to various type annotations Aug 7, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (e41592d) to head (77c2149).
Report is 538 commits behind head on 3.11.

Files with missing lines Patch % Lines
aiohttp/test_utils.py 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             3.11    #8634      +/-   ##
==========================================
+ Coverage   97.55%   97.63%   +0.07%     
==========================================
  Files         108      108              
  Lines       33687    33649      -38     
  Branches     4039     4012      -27     
==========================================
- Hits        32864    32853      -11     
+ Misses        600      591       -9     
+ Partials      223      205      -18
Flag Coverage Δ
CI-GHA 97.54% <92.68%> (+0.08%) ⬆️
OS-Linux 97.22% <92.68%> (+0.08%) ⬆️
OS-Windows 94.73% <85.71%> (+0.05%) ⬆️
OS-macOS 96.89% <92.68%> (+0.07%) ⬆️
Py-3.10.11 97.00% <92.68%> (+0.08%) ⬆️
Py-3.10.14 96.95% <92.68%> (+0.08%) ⬆️
Py-3.11.9 97.18% <92.68%> (+0.08%) ⬆️
Py-3.12.4 97.29% <92.68%> (+0.08%) ⬆️
Py-3.8.10 94.47% <85.71%> (+0.05%) ⬆️
Py-3.8.18 96.84% <92.68%> (+0.04%) ⬆️
Py-3.9.13 97.00% <92.68%> (+0.08%) ⬆️
Py-3.9.19 96.95% <92.68%> (+0.08%) ⬆️
Py-pypy7.3.16 96.53% <92.68%> (+0.08%) ⬆️
VM-macos 96.89% <92.68%> (+0.07%) ⬆️
VM-ubuntu 97.22% <92.68%> (+0.08%) ⬆️
VM-windows 94.73% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit c7293e1 into 3.11 Aug 7, 2024
32 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.11/e0ff5246e1d29b7710ab1a2bbc972b48169f1c05/pr-8620 branch August 7, 2024 16:10
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 7, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/c7293e1963feec47ab237afc8d12a2a252386828/pr-8634

Backported as #8635

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 7, 2024
@Dreamsorcerer @patchback
Backport #8620 as improvements to various type annotations (#8634)
0b88abf 
(cherry picked from commit c7293e1)
@patchback patchback bot mentioned this pull request Aug 7, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 7, 2024
@patchback @Dreamsorcerer
[PR #8634/c7293e19 backport][3.10] Backport #8620 as improvements to …
bf83dbe 
…various type annotations (#8635)

**This is a backport of PR #8634 as merged into 3.11
(c7293e1).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamsorcerer @bdraco