-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix response to circular symlinks with Python v3.13 #8642
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8642 +/- ##
==========================================
+ Coverage 97.66% 97.93% +0.26%
==========================================
Files 108 107 -1
Lines 33852 33669 -183
Branches 4027 3952 -75
==========================================
- Hits 33063 32974 -89
+ Misses 588 515 -73
+ Partials 201 180 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks. I can confirm that this fixes the issue for me. |
Thanks @steverep |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8648 🤖 @patchback |
Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit e494277)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8649 🤖 @patchback |
Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit e494277)
…with Python v3.13 (#8648) Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>
…with Python v3.13 (#8649) Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>
What do these changes do?
In 3.13,
pathlib
has changedPath.resolve()
from always raisingRuntimeError
on circular symlinks to raisingOSError
only whenstrict=True
. To adapt, we either need to resolve strictly, or just catch the error later inFileResponse
. I chose the latter because resolving strictly creates a mess in order to keep the ability to store only compressed files.I also think just catching
OSError
instead ofFileNotFoundError
inFileResponse
is better overall since it may also catch just random file system glitches that would otherwise end up causing a server disconnect.Full disclosure: I did not test this on the 3.13 RC but will ask the issue author to do so.
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
No
Related issue number
Fixes #8565
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.