Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exceptions from WebSocket ping task not being consumed #8685

Merged
merged 15 commits into from
Aug 17, 2024
Merged

Fix exceptions from WebSocket ping task not being consumed #8685

merged 15 commits into from
Aug 17, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 12, 2024 •
edited
Loading

What do these changes do?

Fix exceptions from WebSocket ping task not being consumed

Are there changes in behavior for the user?

No more unexpected un-retrieved exceptions from ping tasks

Is it a substantial burden for the maintainers to support this?

no

Related issue number

related issue home-assistant/core#123653
replaces and closes #7238
fixes #5182
fixes #4153
fixes #2309

@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 12, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (6d3d1fc) to head (4a10ede).
Report is 1062 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8685      +/-   ##
==========================================
+ Coverage   98.13%   98.14%   +0.01%     
==========================================
  Files         107      107              
  Lines       33986    34062      +76     
  Branches     4023     4029       +6     
==========================================
+ Hits        33351    33430      +79     
+ Misses        457      456       -1     
+ Partials      178      176       -2
Flag Coverage Δ
CI-GHA 98.04% <100.00%> (+0.01%) ⬆️
OS-Linux 97.69% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.07% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.35% <100.00%> (+0.01%) ⬆️
Py-3.10.11 97.44% <97.64%> (-0.01%) ⬇️
Py-3.10.14 97.38% <97.64%> (-0.01%) ⬇️
Py-3.11.9 97.63% <97.64%> (+<0.01%) ⬆️
Py-3.12.4 97.73% <97.64%> (-0.01%) ⬇️
Py-3.8.10 95.71% <100.00%> (+0.03%) ⬆️
Py-3.8.18 97.21% <97.64%> (+0.02%) ⬆️
Py-3.9.13 97.35% <97.64%> (+0.03%) ⬆️
Py-3.9.19 97.30% <97.64%> (+0.02%) ⬆️
Py-pypy7.3.16 96.91% <97.64%> (+0.02%) ⬆️
VM-macos 97.35% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.69% <100.00%> (+<0.01%) ⬆️
VM-windows 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 12, 2024
@bdraco bdraco marked this pull request as ready for review August 12, 2024 22:54
@bdraco bdraco mentioned this pull request Aug 17, 2024
Closed
@bdraco bdraco merged commit e7c02ca into master Aug 17, 2024
37 of 38 checks passed
@bdraco bdraco deleted the ping_errors_consumed branch August 17, 2024 15:45
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 17, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/e7c02ca49eac8d9dce197fdcd6273531d0008649/pr-8685

Backported as #8729

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 17, 2024
@bdraco @patchback
Fix exceptions from WebSocket ping task not being consumed (#8685)
caa7e7a 
(cherry picked from commit e7c02ca)
@patchback patchback bot mentioned this pull request Aug 17, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 17, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/e7c02ca49eac8d9dce197fdcd6273531d0008649/pr-8685

Backported as #8730

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 17, 2024
@bdraco @patchback
Fix exceptions from WebSocket ping task not being consumed (#8685)
b56a46c 
(cherry picked from commit e7c02ca)
@patchback patchback bot mentioned this pull request Aug 17, 2024
Merged
bdraco pushed a commit that referenced this pull request Aug 17, 2024
@patchback
[PR #8685/e7c02ca4 backport][3.10] Fix exceptions from WebSocket ping…
0f1a008 
… task not being consumed (#8729)

Co-authored-by: J. Nick Koston <nick@koston.org>
closes #7238
fixes #5182
fixes #4153
fixes #2309
bdraco pushed a commit that referenced this pull request Aug 17, 2024
@patchback
[PR #8685/e7c02ca4 backport][3.11] Fix exceptions from WebSocket ping…
4c6dc7f 
… task not being consumed (#8730)

Co-authored-by: J. Nick Koston <nick@koston.org>
closes #7238
fixes #5182
fixes #4153
fixes #2309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
1 participant
@bdraco