Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List specific timeouts for each exception #8968

Merged
merged 2 commits into from
Sep 2, 2024
Merged

List specific timeouts for each exception #8968

merged 2 commits into from
Sep 2, 2024

Conversation

Dreamsorcerer
Copy link
Member

Fixes #7122, if we're happy with the current status of timeout exceptions.

@Dreamsorcerer Dreamsorcerer added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 1, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (51fade1) to head (9d333c5).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8968   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         107      107           
  Lines       34219    34219           
  Branches     4057     4057           
=======================================
  Hits        33631    33631           
  Misses        415      415           
  Partials      173      173
Flag Coverage Δ
CI-GHA 98.17% <ø> (ø)
OS-Linux 97.83% <ø> (ø)
OS-Windows 96.24% <ø> (ø)
OS-macOS 97.51% <ø> (ø)
Py-3.10.11 97.61% <ø> (ø)
Py-3.10.14 97.54% <ø> (ø)
Py-3.11.9 97.77% <ø> (ø)
Py-3.12.5 97.88% <ø> (ø)
Py-3.9.13 97.50% <ø> (ø)
Py-3.9.19 97.43% <ø> (ø)
Py-pypy7.3.16 97.04% <ø> (-0.01%) ⬇️
VM-macos 97.51% <ø> (ø)
VM-ubuntu 97.83% <ø> (ø)
VM-windows 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco mentioned this pull request Sep 1, 2024
Closed
1 task
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Sep 2, 2024
@Dreamsorcerer Dreamsorcerer merged commit 8daecf5 into master Sep 2, 2024
35 of 36 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch September 2, 2024 00:27
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 2, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/8daecf5cc357518957deec45a526dfd1703ec48b/pr-8968

Backported as #8981

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 2, 2024
@Dreamsorcerer @patchback
List specific timeouts for each exception (#8968)
965e1e7 
(cherry picked from commit 8daecf5)
@patchback patchback bot mentioned this pull request Sep 2, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 2, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/8daecf5cc357518957deec45a526dfd1703ec48b/pr-8968

Backported as #8982

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 2, 2024
@Dreamsorcerer @patchback
List specific timeouts for each exception (#8968)
c8bdac8 
(cherry picked from commit 8daecf5)
@patchback patchback bot mentioned this pull request Sep 2, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Sep 2, 2024
@patchback @Dreamsorcerer
[PR #8968/8daecf5c backport][3.11] List specific timeouts for each ex…
553e311 
…ception (#8982)

**This is a backport of PR #8968 as merged into master
(8daecf5).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Sep 2, 2024
@patchback @Dreamsorcerer
[PR #8968/8daecf5c backport][3.10] List specific timeouts for each ex…
c733c68 
…ception (#8981)

**This is a backport of PR #8968 as merged into master
(8daecf5).**

Co-authored-by: Sam Bull <git@sambull.org>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client raises asyncio.TimeoutError
2 participants
@Dreamsorcerer @bdraco