-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSLContext creation in the TCPConnector with multiple loops #9029
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9029 +/- ##
==========================================
- Coverage 98.30% 98.29% -0.01%
==========================================
Files 107 107
Lines 34355 34349 -6
Branches 4066 4071 +5
==========================================
- Hits 33771 33765 -6
Misses 412 412
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Probably easier to fix the issue and include a test then try to suppress all the asyncio errors that pytest really wants to raise |
I'm not overly convinced we need to support multiple loops, but you didn't change the import_time test, so it can't be that slow to do this on import. |
Need to check the missing coverage |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 466448c on top of patchback/backports/3.10/466448c9412081e1928e08b8a3e413ef4faa1093/pr-9029 Backporting merged PR #9029 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 466448c on top of patchback/backports/3.11/466448c9412081e1928e08b8a3e413ef4faa1093/pr-9029 Backporting merged PR #9029 into master
🤖 @patchback |
I'm not sure why I added skip on this one. I should have done a changelog message |
I'll do another PR to add it #9044 |
(cherry picked from commit 466448c)
(cherry picked from commit 466448c)
…onnector with multiple loops (#9043)
…onnector with multiple loops (#9042)
Creation of the SSLContexts did not account for multiple event loops in different threads.
Creation is now done at import time to ensure it does not block the event loop.
fixes #9020