-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cancellations being swallowed #9030
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #9030 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.01%
==========================================
Files 107 107
Lines 34714 34765 +51
Branches 4116 4123 +7
==========================================
+ Hits 34167 34214 +47
Misses 380 380
- Partials 167 171 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea.
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1a77ad9 on top of patchback/backports/3.10/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030 Backporting merged PR #9030 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1a77ad9 on top of patchback/backports/3.11/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030 Backporting merged PR #9030 into master
🤖 @patchback |
Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit 1a77ad9)
Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit 1a77ad9)
Fixes #8174.
Fixes #8175.