Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancellations being swallowed #9030

Merged
merged 17 commits into from
Sep 23, 2024
Merged

Fix cancellations being swallowed #9030

merged 17 commits into from
Sep 23, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 5, 2024

Fixes #8174.
Fixes #8175.

@Dreamsorcerer Dreamsorcerer added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 5, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 5, 2024
aiohttp/client_reqrep.py Dismissed Show dismissed Hide dismissed
tests/test_client_request.py Dismissed Show dismissed Hide dismissed
tests/test_web_functional.py Fixed Show fixed Hide fixed
tests/test_web_functional.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.41%. Comparing base (7e0ef07) to head (0b1bc0d).
Report is 1044 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/client_reqrep.py 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9030      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         107      107              
  Lines       34714    34765      +51     
  Branches     4116     4123       +7     
==========================================
+ Hits        34167    34214      +47     
  Misses        380      380              
- Partials      167      171       +4     
Flag Coverage Δ
CI-GHA 98.30% <94.11%> (-0.01%) ⬇️
OS-Linux 97.96% <92.64%> (-0.01%) ⬇️
OS-Windows 96.35% <92.64%> (-0.01%) ⬇️
OS-macOS 97.64% <92.64%> (-0.01%) ⬇️
Py-3.10.11 97.62% <39.70%> (-0.12%) ⬇️
Py-3.10.15 97.56% <39.70%> (-0.12%) ⬇️
Py-3.11.10 97.52% <92.64%> (-0.06%) ⬇️
Py-3.11.9 97.59% <92.64%> (-0.06%) ⬇️
Py-3.12.6 98.02% <92.64%> (-0.01%) ⬇️
Py-3.9.13 97.52% <39.70%> (-0.11%) ⬇️
Py-3.9.20 97.46% <39.70%> (-0.11%) ⬇️
Py-pypy7.3.16 97.07% <39.70%> (-0.11%) ⬇️
VM-macos 97.64% <92.64%> (-0.01%) ⬇️
VM-ubuntu 97.96% <92.64%> (-0.01%) ⬇️
VM-windows 96.35% <92.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea.

tests/test_web_functional.py Dismissed Show dismissed Hide dismissed
@Dreamsorcerer Dreamsorcerer merged commit 1a77ad9 into master Sep 23, 2024
33 of 35 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-swallow-cancel branch September 23, 2024 00:39
Copy link
Contributor

patchback bot commented Sep 23, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1a77ad9 on top of patchback/backports/3.10/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030

Backporting merged PR #9030 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030 upstream/3.10
  4. Now, cherry-pick PR Fix cancellations being swallowed #9030 contents into that branch:
    $ git cherry-pick -x 1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e
    If it'll yell at you with something like fatal: Commit 1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix cancellations being swallowed #9030 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Sep 23, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1a77ad9 on top of patchback/backports/3.11/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030

Backporting merged PR #9030 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030 upstream/3.11
  4. Now, cherry-pick PR Fix cancellations being swallowed #9030 contents into that branch:
    $ git cherry-pick -x 1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e
    If it'll yell at you with something like fatal: Commit 1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix cancellations being swallowed #9030 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 1a77ad9)
Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 1a77ad9)
Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 1a77ad9)
Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 1a77ad9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technical CancelledError bubbling up where it should not CancelledError suppressed where it should not
3 participants