-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain the importance of reproducers #9053
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9053 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 107 107
Lines 34356 34356
Branches 4071 4071
=======================================
Hits 33772 33772
Misses 412 412
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5f5a4d2 on top of patchback/backports/3.10/5f5a4d2c320f071391a0c47ecedaf507bcb9a469/pr-9053 Backporting merged PR #9053 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5f5a4d2 on top of patchback/backports/3.11/5f5a4d2c320f071391a0c47ecedaf507bcb9a469/pr-9053 Backporting merged PR #9053 into master
🤖 @patchback |
Not sure if backport matters here as github only looks at master for the issue templates |
Yes. But it may cause problems when backporting other PRs with functional changes that happen to also touch these files for whatever reason… |
@@ -35,6 +35,8 @@ body: | |||
1. Implement the following server or a client '...' | |||
2. Then run '...' | |||
3. An error occurs. | |||
The chances of someone looking at your issue are *vastly* improved if you provide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd put it into the description of the field rather than the placeholder that disappears as soon as somebody clicks on it... check the UX here https://github.com/aio-libs/aiohttp/issues/new?assignees=aio-libs%2Ftriagers&labels=bug&projects=&template=bug_report.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to adjust. I'm not sure how I'd format it into the description.
No description provided.