Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] Remove unused backwards compatibility code in web_urldispatcher for old yarl versions #9084

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2024

What do these changes do?

#9068 (comment)

There are some checks that only existed in 3.11/3.10

As the yarl requirement is not increasing for 3.10, we will keep these shims

yarl >=3.11 is now required for aiohttp 3.11 via #9082

Are there changes in behavior for the user?

no

There are some checks that only existed in 3.11/3.10

As the yarl requirement is not increasing for 3.10, we
will keep these shims

yarl >=3.11 is now required for aiohttp 3.11 via #9082
@bdraco bdraco requested a review from asvetlov as a code owner September 9, 2024 03:06
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport:skip Skip backport bot labels Sep 9, 2024
@bdraco bdraco changed the title Remove unused backwards compatibility code in web_urldispatcher for old yarl versions [3.11] Remove unused backwards compatibility code in web_urldispatcher for old yarl versions Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (64c36e2) to head (2fb992a).
Report is 3164 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9084      +/-   ##
==========================================
+ Coverage   97.69%   98.30%   +0.60%     
==========================================
  Files         108      107       -1     
  Lines       34169    34415     +246     
  Branches     4064     4080      +16     
==========================================
+ Hits        33383    33831     +448     
+ Misses        587      412     -175     
+ Partials      199      172      -27     
Flag Coverage Δ
CI-GHA 98.19% <100.00%> (+0.60%) ⬆️
OS-Linux 97.86% <100.00%> (+0.58%) ⬆️
OS-Windows 96.27% <100.00%> (+1.47%) ⬆️
OS-macOS 97.54% <100.00%> (+0.60%) ⬆️
Py-3.10.11 97.63% <100.00%> (+0.61%) ⬆️
Py-3.10.14 97.57% <100.00%> (+0.59%) ⬆️
Py-3.11.9 97.80% <100.00%> (+0.58%) ⬆️
Py-3.12.4 ?
Py-3.12.5 97.91% <100.00%> (?)
Py-3.8.10 ?
Py-3.8.18 ?
Py-3.9.13 97.52% <100.00%> (+0.59%) ⬆️
Py-3.9.19 97.46% <100.00%> (+0.57%) ⬆️
Py-pypy7.3.16 97.07% <100.00%> (+0.59%) ⬆️
VM-macos 97.54% <100.00%> (+0.60%) ⬆️
VM-ubuntu 97.86% <100.00%> (+0.58%) ⬆️
VM-windows 96.27% <100.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 8109242 into master Sep 9, 2024
36 of 37 checks passed
@bdraco bdraco deleted the remove_back_compat_old_yarl_311 branch September 9, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant