Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keepalive race condition (#9140) #9143

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit 37e3aa4)

(cherry picked from commit 37e3aa4)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (839d060) to head (2b7a204).
Report is 170 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9143   +/-   ##
=======================================
  Coverage   97.77%   97.78%           
=======================================
  Files         108      108           
  Lines       34500    34528   +28     
  Branches     4112     4116    +4     
=======================================
+ Hits        33733    33762   +29     
  Misses        572      572           
+ Partials      195      194    -1     
Flag Coverage Δ
CI-GHA 97.67% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.35% <100.00%> (-0.01%) ⬇️
OS-Windows 94.93% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.04% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.13% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.30% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.37% <100.00%> (-0.03%) ⬇️
Py-3.12.6 96.82% <100.00%> (?)
Py-3.8.10 94.55% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.97% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.57% <100.00%> (+<0.01%) ⬆️
VM-macos 97.04% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.35% <100.00%> (-0.01%) ⬇️
VM-windows 94.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 7531dee into 3.10 Sep 13, 2024
33 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/37e3aa4639193c6423562a4a4dfbf3310772b7a6/pr-9140 branch September 13, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant