Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a cache to must_be_empty_body #9174

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Add a cache to must_be_empty_body #9174

merged 3 commits into from
Sep 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 18, 2024 •
edited
Loading

What do these changes do?

Nearly all the calls are going to be the same so we can cache the logic

I couldn't figure out how to avoid this call in most cases like #9172 so a cache made more sense.

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

before
must_be_empty_body_before

after
must_be_empty_body_after

@bdraco
Add a cache to must_be_empty_body
a2300f9 
Nearly all the calls are going to be the same so we can
cache the logic

related issue #2779
@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 18, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (bf022b3) to head (202810f).
Report is 1048 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9174   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34483    34485    +2     
  Branches     4093     4095    +2     
=======================================
+ Hits        33901    33903    +2     
  Misses        411      411           
  Partials      171      171
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.87% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.28% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 ?
Py-3.11.9 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.40% <100.00%> (-0.19%) ⬇️
Py-3.12.6 97.83% <100.00%> (+0.18%) ⬆️
Py-3.9.13 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.47% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 ?
Py-pypy7.3.16 97.08% <100.00%> (+<0.01%) ⬆️
VM-macos 97.54% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.87% <100.00%> (+<0.01%) ⬆️
VM-windows 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 18, 2024 07:13
webknjaz
webknjaz approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the change note could be made less broad..

@bdraco bdraco mentioned this pull request Sep 18, 2024
Closed
@Dreamsorcerer
Copy link
Member

Looks good, though the change note could be made less broad..

Personally, I don't think these are user-facing really, so all the recent PRs could probably be grouped to a single changenote about performance.

@bdraco
Copy link
Member Author

bdraco commented Sep 18, 2024

Looks good, though the change note could be made less broad..

Personally, I don't think these are user-facing really, so all the recent PRs could probably be grouped to a single changenote about performance.

Will symlink #9169 and #9172 to this one

bdraco
bdraco commented Sep 18, 2024
View reviewed changes
CHANGES/9174.misc.rst Outdated Show resolved Hide resolved
This was referenced Sep 18, 2024
Merged
Merged
@bdraco bdraco merged commit 98b363e into master Sep 18, 2024
34 of 35 checks passed
@bdraco bdraco deleted the cache_must_be_empty_body branch September 18, 2024 14:37
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 18, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/98b363e4fae2200303ad37730eed2ef1b460015d/pr-9174

Backported as #9190

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 18, 2024
@bdraco @patchback
Add a cache to must_be_empty_body (#9174)
3b6c10f 
(cherry picked from commit 98b363e)
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 18, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/98b363e4fae2200303ad37730eed2ef1b460015d/pr-9174

Backported as #9191

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Sep 18, 2024
Merged
patchback bot pushed a commit that referenced this pull request Sep 18, 2024
@bdraco @patchback
Add a cache to must_be_empty_body (#9174)
17c6d09 
(cherry picked from commit 98b363e)
@patchback patchback bot mentioned this pull request Sep 18, 2024
Merged
bdraco added a commit that referenced this pull request Sep 18, 2024
@patchback @bdraco
[PR #9174/98b363e4 backport][3.10] Add a cache to must_be_empty_body (#…
2770e61 
…9190)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Sep 18, 2024
@patchback @bdraco
[PR #9174/98b363e4 backport][3.11] Add a cache to must_be_empty_body (#…
8d7a5ca 
…9191)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer approved these changes

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @Dreamsorcerer @webknjaz