-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up finding the reason if its unset #9175
Conversation
Previously a new enum object had to be created and the reason phase looked up. Since there are a limited number of codes, we can pre-build a dict with all the phases related issue #2779
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9175 +/- ##
=======================================
Coverage 98.31% 98.32%
=======================================
Files 107 107
Lines 34508 34513 +5
Branches 4100 4101 +1
=======================================
+ Hits 33928 33935 +7
+ Misses 410 408 -2
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 756fae8 on top of patchback/backports/3.10/756fae80b824bf1606235962bd2b460b63da4da0/pr-9175 Backporting merged PR #9175 into master
🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9213 🤖 @patchback |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 756fae8)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 756fae8)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 756fae8)
… unset (#9213) Co-authored-by: J. Nick Koston <nick@koston.org>
… unset (#9214) Co-authored-by: pre-commit-ci[bot]
What do these changes do?
Previously a new enum object had to be created and the reason phase looked up. Since there are a limited number of codes, we can pre-build a dict with all the phases which makes the runtime code much simpler
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
related issue #2779
init request
before
after