Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to starting client requests #9386

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 1, 2024

What do these changes do?

Avoid some checks for uncommon cases

Avoid lower()ing default values that are rarely set.

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Oct 1, 2024
@bdraco bdraco changed the title Small speed up to starting client request Small speed up to starting client requests Oct 1, 2024
@bdraco
Copy link
Member Author

bdraco commented Oct 1, 2024

master can handle 13% more RPS than 3.9.5 and the performance is a bit more consistent until gc happens

There is still a lot of time spent in all the update_* functions that we likely can't do much better in:

self.update_version(version)

There are so many options that its always going to be difficult to optimize them without making more invasive changes which probably aren't worth it.

master
aiohttp_master

3.9.5
395

@bdraco bdraco marked this pull request as ready for review October 1, 2024 20:28
@bdraco bdraco requested a review from asvetlov as a code owner October 1, 2024 20:28
@bdraco bdraco enabled auto-merge (squash) October 1, 2024 20:28
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (d684195) to head (0d30abc).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9386   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         107      107           
  Lines       34995    34995           
  Branches     4146     4146           
=======================================
  Hits        34492    34492           
  Misses        335      335           
  Partials      168      168           
Flag Coverage Δ
CI-GHA 98.44% <100.00%> (ø)
OS-Linux 98.10% <100.00%> (ø)
OS-Windows 96.52% <100.00%> (ø)
OS-macOS 97.79% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.66% <100.00%> (ø)
Py-3.10.15 97.65% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.67% <100.00%> (ø)
Py-3.11.9 97.73% <100.00%> (ø)
Py-3.12.6 98.15% <100.00%> (-0.01%) ⬇️
Py-3.13.0-rc.2 98.14% <100.00%> (ø)
Py-3.9.13 97.56% <100.00%> (ø)
Py-3.9.20 97.50% <100.00%> (ø)
Py-pypy7.3.16 97.12% <100.00%> (ø)
VM-macos 97.79% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.10% <100.00%> (ø)
VM-windows 96.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 803d818 into master Oct 1, 2024
40 of 41 checks passed
@bdraco bdraco deleted the start_client_req branch October 1, 2024 21:10
Copy link
Contributor

patchback bot commented Oct 1, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/803d818d1eb2c5fdd9fce4c427d3062b6d39fd6b/pr-9386

Backported as #9388

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 1, 2024
Copy link
Contributor

patchback bot commented Oct 1, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/803d818d1eb2c5fdd9fce4c427d3062b6d39fd6b/pr-9386

Backported as #9389

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 1, 2024
bdraco added a commit that referenced this pull request Oct 1, 2024
…requests (#9388)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Oct 1, 2024
…requests (#9389)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant