Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of fetching the content-length for web responses #9448

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Improve performance of fetching the content-length for web responses #9448

merged 4 commits into from
Oct 10, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 10, 2024 •
edited
Loading

What do these changes do?

Small performance improvement for web responses ~1.8% speed up from avoiding all the multiple super calls

ref #2779 #2779 (comment)

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Oct 10, 2024
Dreamsorcerer
Dreamsorcerer reviewed Oct 10, 2024
View reviewed changes
aiohttp/helpers.py Outdated Show resolved Hide resolved
Dreamsorcerer
Dreamsorcerer reviewed Oct 10, 2024
View reviewed changes
aiohttp/helpers.py Outdated Show resolved Hide resolved
@bdraco @Dreamsorcerer
Update aiohttp/helpers.py
bec1196 
Co-authored-by: Sam Bull <git@sambull.org>
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (c4a3f27) to head (bec1196).
Report is 662 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9448      +/-   ##
==========================================
- Coverage   98.58%   98.58%   -0.01%     
==========================================
  Files         107      107              
  Lines       35012    35010       -2     
  Branches     4146     4145       -1     
==========================================
- Hits        34517    34515       -2     
  Misses        330      330              
  Partials      165      165
Flag Coverage Δ
CI-GHA 98.46% <100.00%> (-0.01%) ⬇️
OS-Linux 98.13% <100.00%> (-0.01%) ⬇️
OS-Windows 96.55% <100.00%> (-0.01%) ⬇️
OS-macOS 97.82% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.69% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.62% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.68% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.77% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 ?
Py-3.12.7 98.18% <100.00%> (+0.42%) ⬆️
Py-3.13.0 98.17% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.59% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.52% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.15% <100.00%> (-0.01%) ⬇️
VM-macos 97.82% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.13% <100.00%> (-0.01%) ⬇️
VM-windows 96.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 10, 2024 13:10
@bdraco bdraco requested a review from asvetlov as a code owner October 10, 2024 13:10
@bdraco bdraco merged commit 93e87c2 into master Oct 10, 2024
38 of 39 checks passed
@bdraco bdraco deleted the content_length_cleanup branch October 10, 2024 13:15
@patchback Patchback
Copy link
Contributor

patchback bot commented Oct 10, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/93e87c2e9cf0fc3a9af29ea9efec0f4c2e37a5b3/pr-9448

Backported as #9449

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 10, 2024
@bdraco @patchback
Improve performance of fetching the content-length for web responses (#…
bb909fb 
…9448)

Co-authored-by: Sam Bull <git@sambull.org>
(cherry picked from commit 93e87c2)
@patchback patchback bot mentioned this pull request Oct 10, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Oct 10, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/93e87c2e9cf0fc3a9af29ea9efec0f4c2e37a5b3/pr-9448

Backported as #9450

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 10, 2024
@bdraco @patchback
Improve performance of fetching the content-length for web responses (#…
ef80e53 
…9448)

Co-authored-by: Sam Bull <git@sambull.org>
(cherry picked from commit 93e87c2)
@patchback patchback bot mentioned this pull request Oct 10, 2024
Merged
bdraco added a commit that referenced this pull request Oct 10, 2024
@patchback @bdraco
[PR #9448/93e87c2e backport][3.10] Improve performance of fetching th…
bc9e5d6 
…e content-length for web responses (#9449)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Oct 10, 2024
@patchback @bdraco
[PR #9448/93e87c2e backport][3.11] Improve performance of fetching th…
7d4b03c 
…e content-length for web responses (#9450)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer left review comments

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @Dreamsorcerer