Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9827/14fcfd4c backport][3.10] Adjust client GET read benchmarks to include chunked and content-length #9829

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 12, 2024

This is a backport of PR #9827 as merged into master (14fcfd4).

chunked has a different performance profile than content-length (chunked is slower currently). We need benchmarks for both.

I'm still not sure if #9823 is a good change or not so I'm adding more benchmarks to validate it

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9829 will not alter performance

Comparing patchback/backports/3.10/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827 (d7f90e7) with 3.10 (ed34333)

Summary

✅ 17 untouched benchmarks

🆕 6 new benchmarks
⁉️ 3 (👁 3) dropped benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827 Change
🆕 test_one_hundred_get_requests_with_1mib_chunked_payload[pyloop] N/A 325.3 ms N/A
🆕 test_one_hundred_get_requests_with_1mib_content_length_payload[pyloop] N/A 305.6 ms N/A
👁 test_one_hundred_get_requests_with_1mib_payload[pyloop] 305.4 ms N/A N/A
🆕 test_one_hundred_get_requests_with_2048_chunked_payload[pyloop] N/A 44.4 ms N/A
🆕 test_one_hundred_get_requests_with_2048_content_length_payload[pyloop] N/A 44.1 ms N/A
👁 test_one_hundred_get_requests_with_2048_payload[pyloop] 44 ms N/A N/A
🆕 test_one_hundred_get_requests_with_32768_chunked_payload[pyloop] N/A 54.4 ms N/A
🆕 test_one_hundred_get_requests_with_32768_content_length_payload[pyloop] N/A 48.4 ms N/A
👁 test_one_hundred_get_requests_with_32768_payload[pyloop] 48.2 ms N/A N/A

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (ed34333) to head (d7f90e7).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9829   +/-   ##
=======================================
  Coverage   97.91%   97.92%           
=======================================
  Files         113      113           
  Lines       35764    35821   +57     
  Branches     4308     4314    +6     
=======================================
+ Hits        35019    35076   +57     
  Misses        553      553           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.81% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.51% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.11% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.21% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.08% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.13% <100.00%> (-0.02%) ⬇️
Py-3.12.7 97.58% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.52% <100.00%> (-0.04%) ⬇️
Py-3.8.10 94.51% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.85% <100.00%> (+0.04%) ⬆️
Py-3.9.13 96.98% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.92% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+<0.01%) ⬆️
VM-macos 97.21% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.51% <100.00%> (+<0.01%) ⬆️
VM-windows 95.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit f2aab2e into 3.10 Nov 12, 2024
39 of 40 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827 branch November 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant