Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9976/2b40f6b7 backport][3.11] Restore only construct the allowed_methods set once for a StaticResource #9979

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 19, 2024

This is a backport of PR #9976 as merged into master (2b40f6b).

Was reverted in #9972 because it introduced a regression with adding and OPTIONS method. Fix the set_options_route call instead and restore the change. There is now test coverage for this case as well via #9975

@bdraco bdraco enabled auto-merge (squash) November 19, 2024 05:35
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (454f914) to head (69cc304).
Report is 3 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9979      +/-   ##
==========================================
+ Coverage   96.65%   98.02%   +1.37%     
==========================================
  Files         120      122       +2     
  Lines       36805    36891      +86     
  Branches     4415     4440      +25     
==========================================
+ Hits        35573    36164     +591     
+ Misses       1004      544     -460     
+ Partials      228      183      -45     
Flag Coverage Δ
CI-GHA 97.92% <100.00%> (+1.31%) ⬆️
OS-Linux 97.62% <100.00%> (?)
OS-Windows 94.52% <100.00%> (?)
OS-macOS 96.74% <100.00%> (+0.13%) ⬆️
Py-3.10.11 96.59% <100.00%> (+0.28%) ⬆️
Py-3.10.15 97.18% <100.00%> (?)
Py-3.11.10 97.20% <100.00%> (?)
Py-3.11.9 96.66% <100.00%> (+0.27%) ⬆️
Py-3.12.7 97.70% <100.00%> (?)
Py-3.13.0 97.68% <100.00%> (?)
Py-3.9.13 96.52% <100.00%> (?)
Py-3.9.20 97.10% <100.00%> (?)
Py-pypy7.3.16 96.66% <100.00%> (?)
VM-macos 96.74% <100.00%> (+0.13%) ⬆️
VM-ubuntu 97.62% <100.00%> (?)
VM-windows 94.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9979 will improve performances by 25.9%

Comparing patchback/backports/3.11/2b40f6b79fae3bc84ff90f7dee6b8e780716d179/pr-9976 (69cc304) with 3.11 (902e7b2)

Summary

⚡ 5 improvements
✅ 38 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/2b40f6b79fae3bc84ff90f7dee6b8e780716d179/pr-9976 Change
test_simple_web_response 637.2 µs 554.3 µs +14.97%
test_simple_web_stream_response 392.9 µs 312.1 µs +25.9%
test_web_response_with_bytes_body 727.5 µs 646.1 µs +12.59%
test_web_response_with_headers 1.2 ms 1.1 ms +8.14%
test_web_response_with_text_body 857 µs 775.8 µs +10.46%

@bdraco bdraco merged commit ee0657d into 3.11 Nov 19, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/2b40f6b79fae3bc84ff90f7dee6b8e780716d179/pr-9976 branch November 19, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant