-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase allowed benchmark run time to 7 minutes #9991
Conversation
We have a lot of benchmarks now. Sometimes they take a bit longer to run and we get unlucky and the job fails https://github.com/aio-libs/aiohttp/actions/runs/11914927085/job/33204143694?pr=9989
CodSpeed Performance ReportMerging #9991 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9991 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 121 121
Lines 36732 36732
Branches 4384 4384
=======================================
Hits 36266 36266
Misses 314 314
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9994 🤖 @patchback |
(cherry picked from commit 7bbbd12)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9995 🤖 @patchback |
(cherry picked from commit 7bbbd12)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9996 🤖 @patchback |
(cherry picked from commit 7bbbd12)
…e to 7 minutes (#9994) Co-authored-by: J. Nick Koston <nick@koston.org>
…e to 7 minutes (#9995) Co-authored-by: J. Nick Koston <nick@koston.org>
…e to 7 minutes (#9996) Co-authored-by: J. Nick Koston <nick@koston.org>
We have a lot of benchmarks now. Sometimes they take a bit longer to run and we get unlucky and the job fails
https://github.com/aio-libs/aiohttp/actions/runs/11914927085/job/33204143694?pr=9989
7 minutes is still shorter than the pypy runs