Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase allowed benchmark run time to 7 minutes #9991

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 19, 2024

We have a lot of benchmarks now. Sometimes they take a bit longer to run and we get unlucky and the job fails

https://github.com/aio-libs/aiohttp/actions/runs/11914927085/job/33204143694?pr=9989

7 minutes is still shorter than the pypy runs

We have a lot of benchmarks now. Sometimes they take a bit longer to run
and we get unlucky and the job fails

https://github.com/aio-libs/aiohttp/actions/runs/11914927085/job/33204143694?pr=9989
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 19, 2024
@bdraco bdraco requested a review from webknjaz as a code owner November 19, 2024 14:34
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9991 will not alter performance

Comparing benchmarks_failing_sometimes (eaf315c) with master (7199e09)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7199e09) to head (eaf315c).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9991   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         121      121           
  Lines       36732    36732           
  Branches     4384     4384           
=======================================
  Hits        36266    36266           
  Misses        314      314           
  Partials      152      152           
Flag Coverage Δ
CI-GHA 98.61% <ø> (ø)
OS-Linux 98.30% <ø> (ø)
OS-Windows 96.13% <ø> (ø)
OS-macOS 97.40% <ø> (-0.01%) ⬇️
Py-3.10.11 97.25% <ø> (+<0.01%) ⬆️
Py-3.10.15 97.79% <ø> (-0.06%) ⬇️
Py-3.11.10 97.84% <ø> (ø)
Py-3.11.9 97.29% <ø> (-0.02%) ⬇️
Py-3.12.7 98.37% <ø> (+<0.01%) ⬆️
Py-3.13.0 98.36% <ø> (ø)
Py-3.9.13 97.17% <ø> (+<0.01%) ⬆️
Py-3.9.20 97.71% <ø> (-0.05%) ⬇️
Py-pypy7.3.16 97.32% <ø> (-0.01%) ⬇️
VM-macos 97.40% <ø> (-0.01%) ⬇️
VM-ubuntu 98.30% <ø> (ø)
VM-windows 96.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as draft November 19, 2024 14:52
@bdraco bdraco marked this pull request as ready for review November 19, 2024 15:08
@bdraco bdraco enabled auto-merge (squash) November 19, 2024 15:08
@bdraco bdraco merged commit 7bbbd12 into master Nov 19, 2024
44 of 45 checks passed
@bdraco bdraco deleted the benchmarks_failing_sometimes branch November 19, 2024 15:16
Copy link
Contributor

patchback bot commented Nov 19, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/7bbbd1267eebf7fad068ae2a1ff827a1db279c8a/pr-9991

Backported as #9994

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 19, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/7bbbd1267eebf7fad068ae2a1ff827a1db279c8a/pr-9991

Backported as #9995

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 19, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/7bbbd1267eebf7fad068ae2a1ff827a1db279c8a/pr-9991

Backported as #9996

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 19, 2024
bdraco added a commit that referenced this pull request Nov 19, 2024
…e to 7 minutes (#9994)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Nov 19, 2024
…e to 7 minutes (#9995)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Nov 19, 2024
…e to 7 minutes (#9996)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant