Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type-anno compatible with Python 3.8 #338

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Apr 25, 2023

What do these changes do?

This is a cherry-pick from #328.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@achimnol achimnol self-assigned this Apr 25, 2023
@achimnol achimnol changed the title fix: Make type-anno compatible with Python 3.8 Make type-anno compatible with Python 3.8 Apr 25, 2023
@achimnol achimnol merged commit 9f776e9 into master Apr 25, 2023
@achimnol achimnol deleted the fix/support-py38-type-anno branch April 25, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant