Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies in document is outdated. #386

Closed
huyx opened this issue Feb 14, 2019 · 0 comments · Fixed by #403
Closed

Dependencies in document is outdated. #386

huyx opened this issue Feb 14, 2019 · 0 comments · Fixed by #403
Labels
pr-merged

Comments

@huyx
Copy link

huyx commented Feb 14, 2019

In the document, it is said that the aiomysql requires "Python 3.3 and asyncio or Python 3.4+":

https://aiomysql.readthedocs.io/en/latest/#dependencies

But in https://github.com/aio-libs/aiomysql, it is said that aiomysql requires "Python 3.5.3".

I think the document is out of date, maybe.

Thanks.
Askaholic added a commit to Askaholic/aiomysql that referenced this issue May 21, 2019
@Askaholic
[aio-libs#386] Update dependencies in docs
76b4349
@Askaholic Askaholic mentioned this issue May 21, 2019
Merged
@helpr helpr bot added the pr-available label May 21, 2019
terricain pushed a commit that referenced this issue May 22, 2019
@Askaholic @terrycain
Fix legacy __aiter__ methods (#403)
8ef840f 
* Fix __aiter__. This breaks compatibility with python < 3.5.2

* [#386] Update dependencies in docs
@helpr helpr bot added pr-merged and removed pr-available labels May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix legacy __aiter__ methods Askaholic/aiomysql
1 participant
@huyx