Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool recylce #216

Merged
merged 3 commits into from
Oct 15, 2017
Merged

Pool recylce #216

merged 3 commits into from
Oct 15, 2017

Conversation

jettify
Copy link
Member

@jettify jettify commented Oct 15, 2017

Based on similar feature from aiopg aio-libs/aiopg#373

@jettify jettify mentioned this pull request Oct 15, 2017
@codecov
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #216 into master will decrease coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   91.78%   91.59%   -0.19%     
==========================================
  Files          12       12              
  Lines        1813     1821       +8     
  Branches      255      256       +1     
==========================================
+ Hits         1664     1668       +4     
- Misses         93       96       +3     
- Partials       56       57       +1
Impacted Files Coverage Δ
aiomysql/sa/engine.py 100% <ø> (ø) ⬆️
aiomysql/pool.py 96.25% <62.5%> (-1.83%) ⬇️
aiomysql/connection.py 87.71% <75%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15115d...f24fc7f. Read the comment docs.

@jettify jettify merged commit f05419e into master Oct 15, 2017
@jettify jettify deleted the pool-recylce branch October 15, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant