Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultProxy __aiter__ issue fixed (#317) #405

Closed
wants to merge 1 commit into from

Conversation

fidemin
Copy link

@fidemin fidemin commented May 19, 2019

What do these changes do?

About issue #317 . The reason of the issue is async def __aiter__ in ResultProxy. async for row in cursor has raise TypeError: 'async for' received an object from __aiter__ that does not implement __anext__: coroutine in 3.7.

Are there changes in behavior for the user?

Nope.

Related issue number

#317

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files           9        9           
  Lines        1180     1180           
  Branches      172      172           
=======================================
  Hits         1089     1089           
  Misses         64       64           
  Partials       27       27
Impacted Files Coverage Δ
aiomysql/sa/result.py 92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131fb9f...9104880. Read the comment docs.

@Askaholic
Copy link
Contributor

This has already been fixed in #403. Have just been waiting on deployment for a month and a half now.

@fidemin fidemin closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants