Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal SQLAlchemy version to 1.3 #815

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

Bump minimal SQLAlchemy version to 1.3.
According to https://www.sqlalchemy.org/download.html all older versions are EOL, 1.3 is still in maintenance state.

Are there changes in behavior for the user?

aiomysql[sa] now requires SQLAlchemy version 1.3.

Checklist

  • Documentation reflects the changes
  • Add a new news fragment into CHANGES.txt

According to https://www.sqlalchemy.org/download.html all older versions are EOL, 1.3 is still in maintenance state
@Nothing4You Nothing4You added dependencies Pull requests that update a dependency file sqlalchemy labels Jul 9, 2022
@Nothing4You Nothing4You added this to the 0.2 milestone Jul 9, 2022
@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #815 (1b6ebb3) into master (57d5b8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          38       38           
  Lines        5569     5569           
  Branches      943      943           
=======================================
  Hits         5164     5164           
  Misses        317      317           
  Partials       88       88           
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.3 89.27% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.4 89.27% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.5 89.26% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.6 89.26% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.7 89.26% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.8 89.26% <ø> (ø)
ubuntu-latest_3.10_mysql-5.7 89.96% <ø> (ø)
ubuntu-latest_3.10_mysql-8.0 91.34% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.3 89.24% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.4 89.24% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.5 89.22% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.6 89.22% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.7 89.22% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.8 89.22% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-5.7 89.92% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-8.0 91.30% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.3 88.67% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 88.67% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 88.66% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 88.66% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.7 88.66% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.8 88.66% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 89.40% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 90.87% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.3 89.32% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 89.32% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 89.30% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 89.30% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.7 89.30% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.8 89.30% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 90.00% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 91.37% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.3 89.17% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 89.17% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 89.15% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 89.15% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.7 89.15% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.8 89.15% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 89.85% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 91.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d5b8e...1b6ebb3. Read the comment docs.

@Nothing4You Nothing4You merged commit c0919b6 into aio-libs:master Jul 9, 2022
@Nothing4You Nothing4You deleted the sqlalchemy branch July 9, 2022 21:04
@Nothing4You Nothing4You modified the milestones: 0.2, SQLAlchemy 1.4 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file sqlalchemy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant