Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated async lock with Python 3.7 #508

Closed
Pajinek opened this issue Oct 11, 2018 · 8 comments
Closed

Deprecated async lock with Python 3.7 #508

Pajinek opened this issue Oct 11, 2018 · 8 comments

Comments

@Pajinek
Copy link

Pajinek commented Oct 11, 2018

I received warning with Python 3.7:

/usr/local/lib/python3.7/site-packages/aiopg/pool.py:46: DeprecationWarning: 'with (yield from lock)' is deprecated use 'async with lock' insteadwith (yield from pool._cond):
@aio-libs-bot

This comment has been minimized.

@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #436 (Python 3.7 compatibility), #136 (Update async generators protocol to support Python 3.5.2/3.6+), #92 (Support async iterator in ResultProxy), and #91 (Support async conext manager for transaction).

@asvetlov
Copy link
Member

This is a tight fork. We have two options:

  1. Drop Python 3.4
  2. Live with the deprecation warning.

@Pajinek
Copy link
Author

Pajinek commented Oct 11, 2018

  1. +1

@gjcarneiro
Copy link
Contributor

+1 to drop Python 3.4.

The latest two Ubuntu LTS releases, and Debian, have newer Python:

  • 16.04 has 3.5.2;
  • 18.04 has 3.6.6;
  • Latest Debian stable (stretch) has 3.5.3.

@Carbaz
Copy link

Carbaz commented Nov 6, 2018

This is a tight fork. We have two options:

  1. Drop Python 3.4
  2. Live with the deprecation warning.

Sooner or later you will have to choose between:

  1. Drop Python 3.4
  2. Drop Python 3.8++

My thumbs up for 1.

@asvetlov
Copy link
Member

asvetlov commented Nov 6, 2018

Any volunteer to replace @asyncio.coroutine / yield from with async def / await?

@gjcarneiro
Copy link
Contributor

I made a PR #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants