-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLAlchemy 2.0 compatibility #901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
+ Coverage 91.77% 93.09% +1.32%
==========================================
Files 9 12 +3
Lines 863 1579 +716
Branches 118 188 +70
==========================================
+ Hits 792 1470 +678
- Misses 53 77 +24
- Partials 18 32 +14
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @mayty, Thank you for the contribution. I have pushed CI changes (not ideal through) to run tests on both major versions of sqlalchemy. |
The changes look reasonable for me, so I am happy to merge and release a new beta version. @mayty Do you want to include any other additional changes into this PR? |
Hi But older version sqlalchemy test should probably be limited to |
Thanks for pointing this out. I have bumped a min supported sqlalchemy version to 1.4. |
@mayty I was thinking to release it as 1.5 with a minor version bump. What do you think? |
I agree |
What do these changes do?
Fix SQLAlchemy 2.0 compatibility
Are there changes in behavior for the user?
No
Related issue number
897.bugfix
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.