Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Towncrier philosophy link #574

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Dec 20, 2023

What do these changes do?

These changes fix a broken link to towncrier's philosophy.

Are there changes in behavior for the user?

Link from Contributing docs to towncrier's philosophy will be fixed.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Add a new news fragment into the CHANGES folder

@Jamim
Copy link
Contributor Author

Jamim commented Dec 20, 2023

To be honest, I don't think this fix deserves a news fragment.
But the Timeline protection doesn't care 😕

@Jamim Jamim force-pushed the fix/towncrier-philosophy-link branch from c00dbbb to 171c7dd Compare December 20, 2023 21:27
@webknjaz webknjaz merged commit d47abef into aio-libs:master Jan 6, 2024
45 checks passed
@Jamim Jamim deleted the fix/towncrier-philosophy-link branch January 6, 2024 21:03
@Jamim
Copy link
Contributor Author

Jamim commented Jan 6, 2024

Hello @webknjaz,

Thank you for merging this PR! 🙇🏼

I've found that there are 8 more broken links like this in aio-libs.
So far I've submitted fixes for two of them.
Do you want me to submit PRs for other libraries or do you want to fix them yourself?

@webknjaz
Copy link
Member

webknjaz commented Jan 7, 2024

Feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants