-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gc track for iterator and pair_list. #321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 10 10
Lines 936 936
=======================================
Hits 875 875
Misses 61 61 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 10 10
Lines 936 936
=======================================
Hits 875 875
Misses 61 61 Continue to review full report at Codecov.
|
I think views should be tracked as well |
Mb I am missing something but all objects created by gc_new in views don't have this problem. |
You are right, sorry. |
LGTM, please merge |
What I should use for merge - "Squash and merge" or "Rebase and merge"? :) |
Squash. |
Ok. I understand. Thank you. |
Resolve #320
Only iterators and pair_list contains this bug.