Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gc track for iterator and pair_list. #321

Merged
merged 1 commit into from
Jan 5, 2019

Conversation

iemelyanov
Copy link
Contributor

@iemelyanov iemelyanov commented Jan 5, 2019

Resolve #320

Only iterators and pair_list contains this bug.

@iemelyanov iemelyanov requested a review from asvetlov as a code owner January 5, 2019 17:11
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          10       10           
  Lines         936      936           
=======================================
  Hits          875      875           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be235c...862b940. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          10       10           
  Lines         936      936           
=======================================
  Hits          875      875           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be235c...862b940. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented Jan 5, 2019

I think views should be tracked as well

@iemelyanov
Copy link
Contributor Author

I think views should be tracked as well

Mb I am missing something but all objects created by gc_new in views don't have this problem.

@asvetlov
Copy link
Member

asvetlov commented Jan 5, 2019

You are right, sorry.
I did look on outdated sources.

@asvetlov
Copy link
Member

asvetlov commented Jan 5, 2019

LGTM, please merge

@iemelyanov
Copy link
Contributor Author

LGTM, please merge

What I should use for merge - "Squash and merge" or "Rebase and merge"? :)

@asvetlov
Copy link
Member

asvetlov commented Jan 5, 2019

Squash.
Please re-read the squashed commit message.
If it is too long or contains non-valuable lines like Fixed tests etc -- edit the message before committing.

@iemelyanov
Copy link
Contributor Author

Squash.
Please re-read the squashed commit message.
If it is too long or contains non-valuable lines like Fixed tests etc -- edit the message before committing.

Ok. I understand. Thank you.

@iemelyanov iemelyanov merged commit 79693fc into aio-libs:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants