Drop wrong key parametrization for concrete classes #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 5 5
Lines 504 504
=======================================
Hits 472 472
Misses 32 32 Continue to review full report at Codecov.
|
psf-chronographer
bot
added
the
bot:chronographer:provided
| @@ -63,9 +63,9 @@ class MutableMultiMapping( | |||
| @abc.abstractmethod | |||
| def popall(self, key: _S, default: _D) -> Union[List[_T], _D]: ... | |||
|
|
|||
| class MultiDict(MutableMultiMapping[_S, _T], Generic[_S, _T]): | |||
| class MultiDict(MutableMultiMapping[str, _T]): | |||
| def __init__(self, arg: _Arg[_S, _T] = ..., **kwargs: _T) -> None: ... | |||
There was a problem hiding this comment.
I think this fails due to the _S. mypy now expects only 1 type in the annotation, but also wants 2 types to be defined (_S, _T), which appears to be impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#677 added generic parameters for keys in accepted mappings and abstract multimapping classes. This is correct.
But the pep also incorrectly added generic key param for concrete classes, e.g.
MultiDict. This is wrong, the key type ofMultiDictis alwaysstrby definition (while the container can accept any str-like keys in its methods, includingistr).The same is true for
CIMultiDict, the key type is alwaysistrwhile any str-like key is accepted and converted internally.