Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to using PyArg_ParseTupleAndKeywords under Python 3.13 #909

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Revert to using PyArg_ParseTupleAndKeywords under Python 3.13 #909

merged 4 commits into from
Jan 16, 2024

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Jan 5, 2024 •
edited
Loading

What do these changes do?

Revert the use of private CPython APIs that don't exist under Python 3.13.

Are there changes in behavior for the user?

Some slow-down, perhaps...

Related issue number

Ref #862

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

This was referenced Jan 5, 2024
Closed
Open
@webknjaz webknjaz mentioned this pull request Jan 14, 2024
Closed
@webknjaz webknjaz changed the title 🧪 Run tests against Python 3.13 in CI Revert to using PyArg_ParseTupleAndKeywords under Python 3.13 Jan 16, 2024
@webknjaz webknjaz force-pushed the bugfixes/py313-_PyArg_Parser branch 5 times, most recently from 550ffe3 to 99884c5 Compare January 16, 2024 15:51
webknjaz added a commit to webknjaz/multidict that referenced this pull request Jan 16, 2024
@webknjaz
Add a note for PR aio-libs#909
8fc4867
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 16, 2024
@webknjaz webknjaz merged commit 61f241f into aio-libs:master Jan 16, 2024
46 checks passed
@webknjaz webknjaz mentioned this pull request Jan 16, 2024
Closed
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 19, 2024
@charles-dyfis-net
Extend aio-libs#909 to 3.12 as well to address aio-libs#926
ad11386
@webknjaz webknjaz mentioned this pull request Jan 20, 2024
Closed
@charles-dyfis-net charles-dyfis-net mentioned this pull request Jan 20, 2024
Merged
3 tasks
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid METH_FASTCALL on Python 3.12 (PR aio-libs#929)
1341d01 
Implemented as an extension of aio-libs#909, which disabled METH_FASTCALL on Python 3.13 and later.

Fixes aio-libs#926.
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid METH_FASTCALL on Python 3.12 (PR aio-libs#929)
4241d0a 
Implemented as an extension of aio-libs#909, which disabled METH_FASTCALL on Python 3.13 and later.

Fixes aio-libs#926.
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid private argument-parsing API on Python 3.12 also
a24e0ba 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid private argument-parsing API on Python 3.12 also
45d6942 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid private argument-parsing API on Python 3.12 also
5176ee3 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid private argument-parsing API on Python 3.12 also
8884206 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Jan 24, 2024
@charles-dyfis-net
Avoid private argument-parsing API on Python 3.12 also
ed0cf16 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).
hoodmane pushed a commit to hoodmane/multidict that referenced this pull request Jan 29, 2024
@charles-dyfis-net @hoodmane
Avoid private argument-parsing API on Python 3.12 also
a2c079f 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Feb 1, 2024
@charles-dyfis-net @webknjaz
Avoid private argument-parsing API on Python 3.12 also
cf3ab55 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Feb 1, 2024
@charles-dyfis-net @webknjaz
Avoid private argument-parsing API on Python 3.12 also
f22c3d6 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Feb 1, 2024
@charles-dyfis-net @webknjaz
Avoid private argument-parsing API on Python 3.12 also
5fb4dce 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Feb 1, 2024
@charles-dyfis-net @webknjaz
Avoid private argument-parsing API on Python 3.12 also
39048ed 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
charles-dyfis-net added a commit to charles-dyfis-net/multidict that referenced this pull request Feb 1, 2024
@charles-dyfis-net @webknjaz
Avoid private argument-parsing API on Python 3.12 also
5ac7591 
Implemented as an extension of aio-libs#909, which made this change on Python 3.13 and later.

Fixes aio-libs#926 (build failure observed with clang-16.0.6 and gcc-14).

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
webknjaz added a commit that referenced this pull request Feb 1, 2024
@webknjaz
Merge PR #929
983411b 
This patch fixes SEGFAULTs under Python 3.12 by using public C-API,
just like with Python 3.13 (#909).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webknjaz