Add tests to have full code coverage of the function _viewbaseset_richcmp
#928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Jan 23, 2024
webknjaz
reviewed
Jan 23, 2024
webknjaz
reviewed
Jan 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 96.99% 98.02% +1.03%
==========================================
Files 20 20
Lines 2227 2280 +53
Branches 199 199
==========================================
+ Hits 2160 2235 +75
+ Misses 53 36 -17
+ Partials 14 9 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
reviewed
Feb 1, 2024
webknjaz
reviewed
Feb 1, 2024
webknjaz
reviewed
Feb 1, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
skinnyBat
force-pushed
the
fully_cover_viewbaseset_richcmp
branch
from
bcbaf36
to
353d191
Compare
…on versions prior to 3.11.
webknjaz
reviewed
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add tests to improve the code coverage of
_multidict_base_py, by fully covering the_viewbaseset_richcmpfunction.Are there changes in behavior for the user?
None
Related issue number
Partially addresses #921.
Checklist