-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Trailing slash for yarl.URL ("http://localhost") / "path" / "" is dropped in 1.9.4 #984
Closed
1 task done
Labels
Comments
This is actually a regression of version 1.9.1. Please guys fix this, or at least document it in the changelog as it's quite a breaking change! |
Feel free to send a PR with regression tests and possibly fixes. I don't think I'll have time to work on this myself. |
3 tasks
Done: #1023 |
3 tasks
webknjaz
added a commit
that referenced
this issue
Jul 3, 2024
The patch makes `yarl.URL()` objects preserve empty segments when joining additional parts in cases like ```python URL("https://web.archive.org/web/") / "https://github.com/" ``` PR #1026 Fixes #926 Fixes #984 Closes #1023 Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> Co-authored-by: Alessio Bogon <778703+youtux@users.noreply.github.com>
Hey guys, could you release a new version with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
yarl 1.8.2 allowed to construct URLs with trailing slashes like that:
yarl 1.9.4 drops the slash from that path. Possibly related to #862 :
To Reproduce
Try 1.8.2 vs 1.9.4 with the code above.
Expected behavior
Preserve the slash
Logs/tracebacks
Python Version
Python 3.11.6
multidict Version
yarl Version
OS
Ubuntu 23.10
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: