Make raw_host and port cached_property #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiohttp accesses these properties quite often because of the calls to is_absolute and urllib has to reparse _hostinfo each time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 62.36% 62.36%
=======================================
Files 38 38
Lines 6616 6616
Branches 356 356
=======================================
Hits 4126 4126
Misses 2463 2463
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
commented
Aug 9, 2024
webknjaz
reviewed
Aug 13, 2024
webknjaz
reviewed
Aug 13, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
bdraco
commented
Aug 14, 2024
|
I tried to fix the chronographer in #1053 but it looks like its coming in from the org level and not in the github config so its not something I have access to solve. |
|
It looks like changelog checks haven't been working for a while per #954 (comment) |
|
Added skip label as a workaround since changelog bot is currently not working |
bdraco
added
the
bot:chronographer:skip
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
aiohttp accesses these properties quite often because of the calls to
is_absolute/update_headersandurllibhas to reparse_hostinfoeach time.Are there changes in behavior for the user?
No