Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust many url and many hosts benchmarks to reduce CI run time #1236

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 12, 2024

The last release failed because the tests took too long
https://github.com/aio-libs/yarl/actions/runs/11307702438/job/31449999361

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 12, 2024
@bdraco
Copy link
Member Author

bdraco commented Oct 12, 2024

 25.04s call     tests/test_quoting.py::test_fuzz__PyQuoter
  7.50s call     tests/test_quoting.py::test_quote_unquote_parameter_path_safe[PyUnquoter-PyQuoter]
  2.23s call     tests/test_quoting.py::test_quote_unquote_parameter_path_safe[PyUnquoter-CQuoter]
  2.08s call     tests/test_quoting.py::test_quote_unquote_parameter_path_safe[CUnquoter-PyQuoter]
  1.51s call     tests/test_quoting.py::test_fuzz__PyUnquoter
  1.06s call     tests/test_quoting.py::test_quote_unquote_parameter_path_safe[CUnquoter-CQuoter]
  0.90s call     tests/test_quoting.py::test_quote_unquote_parameter_requote[PyUnquoter-CQuoter]
  0.88s call     tests/test_quoting.py::test_quote_unquote_parameter_requote[PyUnquoter-PyQuoter]
  0.86s call     tests/test_quoting.py::test_quote_unquote_parameter[CUnquoter-PyQuoter]
  0.86s call     tests/test_quoting.py::test_quote_unquote_parameter[CUnquoter-CQuoter]

Looks like hypothesis is more of an issue

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (5c04558) to head (f133875).
Report is 204 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1236   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          27       27           
  Lines        5085     5085           
  Branches      302      302           
=======================================
  Hits         4870     4870           
  Misses        189      189           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.75% <100.00%> (ø)
MyPy 43.31% <100.00%> (ø)
OS-Linux 99.34% <100.00%> (ø)
OS-Windows 99.40% <100.00%> (ø)
OS-macOS 99.05% <100.00%> (ø)
Py-3.10.11 98.95% <100.00%> (ø)
Py-3.10.15 99.22% <100.00%> (ø)
Py-3.11.10 99.22% <100.00%> (ø)
Py-3.11.9 98.95% <100.00%> (ø)
Py-3.12.7 99.22% <100.00%> (ø)
Py-3.13.0 99.22% <100.00%> (ø)
Py-3.8.10 98.90% <100.00%> (ø)
Py-3.8.18 99.17% <100.00%> (ø)
Py-3.9.13 98.90% <100.00%> (ø)
Py-3.9.20 99.17% <100.00%> (ø)
Py-pypy7.3.11 99.22% <100.00%> (ø)
Py-pypy7.3.16 99.22% <100.00%> (ø)
Py-pypy7.3.17 99.25% <100.00%> (ø)
VM-macos-latest 99.05% <100.00%> (ø)
VM-ubuntu-latest 99.34% <100.00%> (ø)
VM-windows-latest 99.40% <100.00%> (ø)
pytest 99.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #1236 will improve performances by ×2.5

Comparing adjust_many_tests (f133875) with master (5c04558)

Summary

⚡ 2 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark master adjust_many_tests Change
test_url_build_with_different_hosts 6.6 ms 2.6 ms ×2.5
test_url_make_with_many_hosts 13.3 ms 6.7 ms +97.95%

@bdraco
Copy link
Member Author

bdraco commented Oct 12, 2024

speed up isn't really, this is a change in the test

@bdraco bdraco merged commit ca035aa into master Oct 12, 2024
49 of 51 checks passed
@bdraco bdraco deleted the adjust_many_tests branch October 12, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant