Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable running hypothesis tests under cibuildwheel #1238

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 12, 2024

What do these changes do?

Some of these tests take more than 25s+ when building wheels and the test times were getting to be significantly longer than the build times (almost an order of magnitude under qemu)

fixes #1237

Previous build failed due to timeout https://github.com/aio-libs/yarl/actions/runs/11307702438

Are there changes in behavior for the user?

no

Some of these tests take more than 25s+ when building wheels

fixes #1237

Previous build failed due to timeout https://github.com/aio-libs/yarl/actions/runs/11307702438
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (ca035aa) to head (459cc20).
Report is 203 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          27       27           
  Lines        5085     5092    +7     
  Branches      302      302           
=======================================
+ Hits         4870     4877    +7     
  Misses        189      189           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.75% <100.00%> (+<0.01%) ⬆️
MyPy 43.39% <100.00%> (+0.08%) ⬆️
OS-Linux 99.34% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.40% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.05% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.95% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.22% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.22% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.95% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.22% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.22% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.90% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.17% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.90% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.17% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.22% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.22% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.25% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.05% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.34% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.40% <100.00%> (+<0.01%) ⬆️
pytest 99.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #1238 will not alter performance

Comparing disable_hypothesis_cibuildwheel (459cc20) with master (ca035aa)

Summary

✅ 39 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review October 12, 2024 21:22
@bdraco bdraco merged commit 33bb5ee into master Oct 12, 2024
49 of 51 checks passed
@bdraco bdraco deleted the disable_hypothesis_cibuildwheel branch October 12, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hypothesis tests take too long under qemu
1 participant