Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string subclasses in truediv operations #884

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mjpieters
Copy link
Contributor

Fixes #871

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #884 (6ddd3e6) into master (15f2455) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
  Branches      219      219           
=======================================
  Hits          770      770           
  Misses          2        2           
Flag Coverage Δ
unit 99.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
yarl/_url.py 99.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mjpieters mjpieters force-pushed the path_div_str_subclass branch from a4905e2 to 6ddd3e6 Compare June 7, 2023 13:47
@mjpieters mjpieters enabled auto-merge (squash) June 7, 2023 13:49
@mjpieters mjpieters merged commit c3111ef into master Jun 7, 2023
@mjpieters mjpieters deleted the path_div_str_subclass branch June 7, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError on URL join with enum.StrEnum classes for yarl==1.9.1+
1 participant