Inconsistent behaviour between Cython and CPython (or lack of docs, or both) #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should really finish up #860 to catch the differences better... |
webknjaz
reviewed
Feb 12, 2024
tests/test_url_parsing.py
Outdated
| assert u.query_string == "" | ||
| assert u.fragment == "Pünktelchen\udca0\udcef\udcb6" | ||
| assert u.path == u2.path | ||
| # assert u.fragment == u2.fragment |
There was a problem hiding this comment.
Suggested change
| # assert u.fragment == u2.fragment |
webknjaz
reviewed
Feb 12, 2024
| @@ -584,3 +584,34 @@ def test_empty_path(self): | |||
| assert u.path == "" | |||
| assert u.query_string == "" | |||
| assert u.fragment == "" | |||
|
|
|||
| def test_truncated_utf_sequence(self): | |||
There was a problem hiding this comment.
If path is the only difference, could you parametrize the test?
webknjaz
force-pushed
the
test-cmod-utfseq
branch
from
bc8a244 to
753781a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 95.88% 95.83% -0.06%
==========================================
Files 27 27
Lines 5303 5331 +28
Branches 316 316
==========================================
+ Hits 5085 5109 +24
- Misses 192 196 +4
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #991 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds a test for the quoting inconsistency that I believe needs change. It is written such that the compiled module passes but setting
YARL_NO_EXTENSIONS=1fails.Submitting without the desired change to verify CI results. May or may not add actual content eventually.
Are there changes in behavior for the user?
No, but maybe there should be. Telling the user they are responsible about URL correctness is not particularly useful if the specific correctness properties are not enumerated.
Related issue number
Still roughly the same scenario, just moved from aio-libs/aiohttp#8088 where it was unnecessarily tested for, and thus failed on PyPy
Checklist