Rebase/elastic search #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmatias
approved these changes
May 29, 2024
There was a problem hiding this comment.
This PR also solves the issue with searching for assets of specific platforms using the platforms field.
I also noticed that the platforms are validated against the platforms defined in the enum class which doesn't allow searching for assets from newly added platforms such as "aida_cms," "bonseyes," and others. This has already been reported in another issue #308 for other endpoints, and I'll update it with this information so it can be solved in another PR.
Other than that, I think we can merge this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adrian's branch, but rebased to change the commit that removed the files in the
datadirectory to not remove those (but keep other changes).