Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractDetails refactoring and testing #1108

Merged
merged 17 commits into from
Jan 30, 2020
Merged

ContractDetails refactoring and testing #1108

merged 17 commits into from
Jan 30, 2020
+684 −275

Conversation

AlexandraRoatis
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis commented Jan 22, 2020 •
edited
Loading

  • Reduced some of the complexity of the AionContractDetailsImpl.
  • Benchmarked the utility of the storage transition.

@AlexandraRoatis AlexandraRoatis added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 22, 2020
@AlexandraRoatis AlexandraRoatis self-assigned this Jan 22, 2020
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-435 branch 10 times, most recently from 0608efe to 2880284 Compare January 28, 2020 20:56
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-435 branch 2 times, most recently from 07a371d to 0608efe Compare January 29, 2020 15:38
@AlexandraRoatis AlexandraRoatis changed the title WIP - AKI-435 ContractDetails refactoring and testing Jan 29, 2020
@AlexandraRoatis AlexandraRoatis added enhancement New feature or request unit tests labels Jan 29, 2020
@AlexandraRoatis AlexandraRoatis added this to the 1.3 milestone Jan 29, 2020
@AlexandraRoatis AlexandraRoatis removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 29, 2020
@AlexandraRoatis
Replaced setDirty(boolean) method with markAsDirty() since the settin…
cc83291 
…g is one way only.
@AlexandraRoatis
Removed unused prune setting from AionContractDetailsImpl.
5debc75
@AlexandraRoatis
Removed test constructor:
4583867 
 - detailsInMemoryStorageLimit converted to static and tagged as @VisibleForTesting;
 - removed unnecessary use of detailsInMemoryStorageLimit.
@AlexandraRoatis
Replaced setDataSource method with constructor in tests.
3782524
@AlexandraRoatis
Removed caching of contractObjectGraphSource (cumbersome premature op…
dbb543e 
…timisation).
@AlexandraRoatis
Removed caching of externalStorageDataSource (cumbersome premature op…
52a1ee8 
…timisation):

 - replace test specific method setExternalStorageDataSource with more restrictive option;
 - corrected testExternalStorageTransition to test the actual transition functionality;
@AlexandraRoatis
Limited access to externalStorage flag.
00960d9
@AlexandraRoatis
Removed cached encoding of AionContractDetailsImpl:
e2c7bb3 
 - storing the encoding increases the complexity of the code with very little benefit;
 - the encoding is computed only once at commit, but copied many times if cached;
@AionJayT AionJayT self-requested a review January 30, 2020 19:02
@AlexandraRoatis AlexandraRoatis merged commit e5f8416 into master Jan 30, 2020
@AlexandraRoatis AlexandraRoatis deleted the AKI-435 branch January 30, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT AionJayT approved these changes

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
enhancement New feature or request unit tests
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandraRoatis @AionJayT