Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-231 should clarify whether it permits batch-getting top-level resources #599

Closed
apasel422 opened this issue Aug 24, 2020 · 0 comments · Fixed by #602
Closed

AIP-231 should clarify whether it permits batch-getting top-level resources #599

apasel422 opened this issue Aug 24, 2020 · 0 comments · Fixed by #602

Comments

@apasel422
Copy link
Contributor

apasel422 commented Aug 24, 2020

And if so, whether that implies that the parent field should be omitted from the request and the URI pattern.

If that's the case, we should also update the linter, as it appears to have false positives around things like

rpc BatchGetWidgets(BatchGetWidgetsRequest) returns (BatchGetWidgetsResponse) {
    option (google.api.http) = {
      get: "/v2/widgets:batchGet"
    };
}

as the GET URI doesn't match the regex {[a-zA-Z=/*]+}/[A-Za-z0-9-=/*]+:batchGet$ at https://github.com/googleapis/api-linter/blob/c6ca8351663b4679ba5a8c571dfede4ff4d22228/rules/aip0231/aip0231.go#L45.

Other linters that need to be updated if so are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant