feat: support executing bin again when bin exit #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
work in progress? |
xiantang
reviewed
Dec 9, 2022
|
I supposed that you need to add a test case like this: when executing bin exit should restart the bin again, because our old behavior don't have this |
amikai
changed the title
amikai
force-pushed
the
amikai-i353-2
branch
from
ff66e79
to
2235250
Compare
|
Do we need to append a document for this? |
amikai
commented
Dec 11, 2022
Finish 1c71714 |
xiantang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #353