Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not sleep to kill a process that has already cleaned up and exited by itself #672

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

do not sleep to kill a process that has already cleaned up and exited by itself #672

wants to merge 5 commits into from

Commits on Nov 1, 2024

  1. abort kill delay if process closes after interrupt 

    if the process to be killed honours the SIGINT and closes down,
we should not sleep before trying to kill a process that is
no longer there
    @istyf
    istyf committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4d26204 View commit details
    Browse the repository at this point in the history

  2. make sure to wait for both wait and kill results when kill delay is 0

    @istyf
    istyf committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ffd34c9 View commit details
    Browse the repository at this point in the history

  3. use cmd.process.signal and cmd.process.kill instead of raw syscalls

    @istyf
    istyf committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    45409a0 View commit details
    Browse the repository at this point in the history

  4. switch back to syscall as os.process.signal or kill do not signal the… 

    … entire group
    @istyf
    istyf committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4d976a7 View commit details
    Browse the repository at this point in the history

  5. remove unstable and slightly dangerous kill test 

    the test paniced if it ever got a nil err since t.Failf does not
imply that test is stopped

selecting a random pid to kill might have interesting side effects
when run and its result can never be guaranteed to be the same, meaning
that the test had intermittent failures

no code depends on the specific return code of killCmd, so there
does not seem to be a reason to have a unit test for it
    @istyf
    istyf committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    52428bf View commit details
    Browse the repository at this point in the history