Don't force location permissions #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwadams
force-pushed
the
nick-dont-force-location-permissions
branch
from
1f98389
to
1c0cd8e
Compare
|
Thanks @nwadams! Do you know when a release will be cut with this fix included? CC @felipecsl |
|
@forrestbice you can grab the snapshot version right now with |
|
Awesome! Thanks @felipecsl |
|
@nwadams @felipecsl just opened a very similar issue #103 and a PR #104 which will hopefully address the issue. Would greatly appreciate a quick look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force enabling location permissions when loading map. First commit needs to be taken out once the PR for it is merged.
Resolves #97
@felipecsl @petzel @gpeal