Require a non-zero length param value #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now (and I believe as of 1.5.0), we're seeing a bug where
DeepLinkEntry
matches against Uris with empty params improperly.For instance - If you have:
You'll find that the second URI is matched - with an empty id, rather than matching the first path. Additionally, you'll see that routes like
dld://foo/{id}/bar
are incorrectly matching against things likedld://foo//bar
. Changing the Regex operator to require a character match would fix these two issues.Also, for an added bonus - I think the first case is obscured based on the order that the entries are listed in the Loader - which is based on the name of the Activity.