Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a non-zero length param value #102

Merged
merged 2 commits into from
Jun 6, 2016

Conversation

MichaelEvans
Copy link
Contributor

Right now (and I believe as of 1.5.0), we're seeing a bug where DeepLinkEntry matches against Uris with empty params improperly.

For instance - If you have:

dld://foo
dld://foo/{id}

You'll find that the second URI is matched - with an empty id, rather than matching the first path. Additionally, you'll see that routes like dld://foo/{id}/bar are incorrectly matching against things like dld://foo//bar. Changing the Regex operator to require a character match would fix these two issues.

Also, for an added bonus - I think the first case is obscured based on the order that the entries are listed in the Loader - which is based on the name of the Activity.

@ZacSweers
Copy link
Contributor

👍

@felipecsl
Copy link
Collaborator

Thank you!

@felipecsl felipecsl merged commit dcfd47c into airbnb:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants