Add support for export default #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 14, 2018
ljharb
reviewed
Nov 14, 2018
There was a problem hiding this comment.
This looks great overall, thanks! I’m a bit hesitant about the camelize/capitalize approach, but i don’t have a better suggestion.
I wonder if it would be better to leave it anonymous in that case, but set the displayName property to directly match the filename?
jb-san
force-pushed
the
export
branch
2 times, most recently
from
ff409ef to
fcda0e3
Compare
ljharb
reviewed
Nov 25, 2018
|
anything else that needs fixing ? |
|
should i just close this ? im using it in a project and everything is working, but i can just make a private repo and use that |
|
@jb-san please don't; sorry for the delays but my time is limited. I'll plan to merge and release this as soon as i can. |
ljharb
approved these changes
Apr 9, 2019
ljharb
added a commit
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the ability to do
export { default } from ...andexport { default as Icon } from ...this is my first time doing anything with babel, so criticism is welcome..