Force-remove mocks after tests to fix batcher invocation during deploy #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #28 introduced
moto
to the unit test framework, the batcher invocation duringpython3 manage.py deploy
breaks with an error like the following:Due to getmoto/moto#1026,
moto
mocks are not always restored correctly. This means that after the unit tests run, part ofboto3
was still mocked out.As a simple workaround, I've added a decorator which manually restores the underlying
HTTPAdapter
after running the unit test suite.Other Minor Changes
ThrottledRequests
instead ofReadThrottleEvents
specificallyTested
CI and deployed to an empty test account. Batcher invocation was successful during the test deploy.
Reviewers
to: @ryandeivert
cc: @airbnb/binaryalert-maintainers