Extract widget javascript to separate files. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuhn
added a commit
that referenced
this pull request
Sep 30, 2015
Extract widget javascript to separate files.
hughhhh
referenced
this pull request
in lyft/incubator-superset
Apr 1, 2018
Project superset-at-lyft is used and configured here: https://console.developers.google.com/apis/credentials/oauthclient/66693564572-aq60djhno9rd2nfo0nbt3aurkoqntdjm.apps.googleusercontent.com?project=superset-at-lyft Added hmiles@lyft.com as another owner of this Google project The flow isn't super great and we could alter it by overriding the login view to simply show a [login with google] button instead of what is shown now
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Apr 4, 2018
…ager_refactor -Cherrypick security manager refactor
betodealmeida
pushed a commit
that referenced
this pull request
Sep 20, 2019
Merge latest from apache:lyft-develop
This was referenced Aug 27, 2020
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
BREAKING CHANGE: rename D3Formatter to D3NumberFormatter
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 24, 2021
BREAKING CHANGE: rename D3Formatter to D3NumberFormatter
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 24, 2021
* fix: pie chart exception * fix: incoporate krist's feedbacl
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 25, 2021
BREAKING CHANGE: rename D3Formatter to D3NumberFormatter
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 25, 2021
* fix: pie chart exception * fix: incoporate krist's feedbacl
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 26, 2021
BREAKING CHANGE: rename D3Formatter to D3NumberFormatter
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 26, 2021
* fix: pie chart exception * fix: incoporate krist's feedbacl
zhaoyongjie
added a commit
that referenced
this pull request
Nov 30, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards a cleaner abstraction for defining widgets.
Test plan
panoramix/bin/panoramix load_examples